Mingun

Results 397 comments of Mingun

Wait on merge it this, I found that tests are incomplete. In case of ```xml ``` we always should use spaces, but now indent symbols are used. The fix is...

Yes, I also think, that mixing indentation symbols is a bad idea, because some editors can easily break things by replacing spaces with tabs, but auto-selecting behaviour based on intendation...

Yes, I think, this is undesired behavior and we need to fix it

Yes, nice addition. Could you also add a changelog entry? Some tests would be also good -- maybe add a doc example?

I modified your PR slightly, I hope I didn't lost something important: - squashed all commits - rename `inner` to `get_ref` to match the default Rust agreement (see [standard library](https://doc.rust-lang.org/std/io/struct.Cursor.html?search=get_ref#method.get_ref))...

I cannot say what the reason of this without the full code, but I believe that you've get the text between `` and next ``. You should check that your...

Also, just consuming `Event::Text`s is error-prone. In XML all text events should be concatenated together with CDATA contents and you should drop any comments between them. The code that takes...

I squashed all commits, refactor our code a bit and move tests to doctests. I didn't include `escape_with` method, because it is not used in quick-xml and it is easy...

I checked, and this PR does not solve #347, but solve #683, because it actually does the same thing as #702. Unfortunately, #683 and #347 seems to contradict each other....

> Furthermore, I think it would be _wrong_ to use a serde field name of `ns1:element` unless going for a pure, pre https://www.w3.org/TR/xml-names/ tag/attribute name handling mode. Yes, I agree...