Michael Chirico

Personally I don't see much value to usage like this -- The idea is never to use a literal in an if/while condition? Is this covered in some style guide?

Also related: our `PasteFilePathLinter()` from #884 which didn't make the 3.0.0 cut: > PasteFilePathLinter - Block usage of paste() with sep='/'

that message is certainly no good :) FWIW, all linters' are factories since 3.0.0 -- that means all your entries should be converted to function calls, e.g. ``` -assignment_linter =...

I reproduce the issue: ```shell cd /tmp echo "linters: linters_with_defaults(assignment_linter = lintr::assignment_linter)" > .lintr echo "a = 1" > file.R Rscript -e "lintr::lint_dir()" # Error: Linter 'assignment_linter' failed in /tmp/file.R:...

Somehow, the factory is not being evaluated, `assignment_linter` is being run on the expression, i.e., the error is essentially: ```r assignment_linter(get_source_expressions("file.R")$expressions[[1L]]) # Error in if (allow_cascading_assign) "" else "[text() =...

Great! Glad to un-break you. Leaving the issue open because it should fail in a much friendlier way for you to unstick yourself.

Even better than just detecting issues, if we can `warn()`, fix, and continue, that's even better. (2) in particular strikes me as something that we should be flexible on. Is...

I think at least we can recommend users to namespace-qualify packages if they want lintr to work properly. That should work pretty well for us.

@renkun-ken is this the same as your #837?

I'm not sure how to answer about their storage, but the Hive type is `array` and/or `map`. Though those types are potentially recursive (and hence highly complex), I've only used...