Michael Chirico comments

Results 322 comments of


Michael Chirico

Dplyr, specify what is column, and what is variable

Looking again, I encourage this as a custom linter in downstream. Unless {tidyverse} authors themselves tout this approach, I think it's out of scope.

Use cache object

Gonna close since this is so far diverged from `main` / not much apparent appetite for working on it. Feel free to tackle from scratch on current `main`.

Linter for package code that is not within a function

Happy to support anyone trying to implement this, but it seems there's not much interest.

Include the expression ID in the Lint object

Agree there's not much use for this at this point, especially given the technical blockers.

`release_bullets()` for future releases?

What's discussed here is seen in .dev/revdep*. We can add more incrementally later, not sure I see a reason to keep this open now.

simple comment triggers commented_code_linter

> define some kind of minimal complexity that the potentially commented code must have when parsed? I am converging on this being the right approach. Such a metric can be...

Throw lint for grepl("^", x) in string_boundary_linter

FWIW, there's no code doing this on GitHub: https://github.com/search?q=%2Fgrep%5Bl%5D%3F%5B(%5D%2F%20%2F%5B%22%5D%5B%5E%5D%5B%22%5D%2F%20lang%3AR&type=code

Writing R code in a DCF is unappealing

@HaHeho Could you share an R file that's giving you this issue (in a new bug report please)? .lintr.R is plain R code, completely independent of DCF implementation, so there...

Writing R code in a DCF is unappealing

> Should I file a bug report for this one? Indeed it looks like a bug, thanks! This `read.dcf()` usage needs to be updated: https://github.com/r-lib/lintr/blob/106dfb4036a63d8bbe211b0989ad09723fd0f312/R/addins.R#L15 Please file a new bug.

New `return_linter` to enforce consistent return style

FYI @mjsteinbaugh and @givison there's a pending version in #2271