Michael Chirico

Results 349 comments of Michael Chirico

Encourage anyone that's interested to file PRs. Would especially be nice to include some for the 3.0.0 release. A lot of the points referenced in https://github.com/r-lib/lintr/issues/43#issuecomment-552857792 are already doable with...

Great observation! I would rather name it `which_optimum_linter()`, or combine it with the pending `which_grepl_linter()` from #884 and just call it `which_linter()` more generally

A different way to go would be to add an option recognized in `.lintr`, then throw a `warning()` from `exclude` that an unqualified `# nolint` was found and is being...

Default would be for it to be off (at least for now), so no warnings unless intentionally toggled

Hi @jimhester I see the patch still hasn't landed on CRAN. If it's possible, we may just want to send a full 3.0.2 release. I think the current main is...

SG, thanks for handling this!

tests/ is fine. how about skipping on R/ instead? we could check for a NAMESPACE too for robustness. On Thu, Sep 8, 2022, 8:49 AM Hugo Gruson ***@***.***> wrote: >...

the issue is referring to when _internal_ chunks have trailing blank lines, say chunk 2 out of 3

no, but your example works. chunk 1 has trailing blank lines after `some code`, chunk 2 does not