Michael Chirico

Results 349 comments of Michael Chirico

by "bodies" i meant to exclude the first and last line, e.g. ``` x

We do have loads of long file names, but usually it's because of the leading directories, and that can be solved using `file.path()`. OTOH, we also have a lot of...

It's coming from here, not sure why it's only happening in that workflow though: https://github.com/r-lib/lintr/blob/4b37029f989629287e910fa3aba46ab15d1975cb/tests/testthat/test-unreachable_code_linter.R#L124-L138

> Also, should I add myself as a contributor? So far, the Contributor list is only recording folks with a "substantial" contribution history

please update to `main` and re-document to resolve the conflict, thanks!

Looking great! Thanks again for your work here. Getting much closer to the finish line! 🏁

i personally like the `!x %in% tbl` approach (especially in if() clauses where the added parens tend to clutter) but agree it would be a good linter to offer!

Related issue coming up in #1656: --- Currently, the linter marks `x %>% ... %>% length(.) > 0` This _technically_ works as intended because it's parsed as `` `>`(x %>%...

I do like the idea but worry about suggesting an R 4 dependency, maybe off by default until 4.x.y is released? or even 5.0.0?

👍 I also had in mind to write some linter(s) around skip() in testthat, how about just skip_linter() / testthat_skip_linter() and add parameters about what sorts of usages to detect