lintr icon indicating copy to clipboard operation
lintr copied to clipboard

Add sort_linter()

Open Bisaloo opened this issue 2 years ago • 4 comments

Fix #1512

I'm happy to receive feedback on this PR and revisit as much as needed. I'm not super familiar with XPath so I did the best I could.

Also, should I add myself as a contributor?

Bisaloo avatar Sep 01 '22 15:09 Bisaloo

Also, should I add myself as a contributor?

So far, the Contributor list is only recording folks with a "substantial" contribution history

MichaelChirico avatar Sep 19 '22 07:09 MichaelChirico

Codecov Report

Merging #1528 (7aec406) into main (9bb8b63) will increase coverage by 0.01%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1528      +/-   ##
==========================================
+ Coverage   98.88%   98.89%   +0.01%     
==========================================
  Files         109      110       +1     
  Lines        4648     4692      +44     
==========================================
+ Hits         4596     4640      +44     
  Misses         52       52              
Impacted Files Coverage Δ
R/sort_linter.R 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov-commenter avatar Oct 06 '22 21:10 codecov-commenter

please update to main and re-document to resolve the conflict, thanks!

MichaelChirico avatar Oct 11 '22 18:10 MichaelChirico

Looking great! Thanks again for your work here. Getting much closer to the finish line! 🏁

MichaelChirico avatar Oct 11 '22 18:10 MichaelChirico

Oops, sorry for the spam, I was trying to request another round of review from both reviewers but looks like I can only select one at a time, hence the confusion :disappointed:

Bisaloo avatar Nov 21 '22 09:11 Bisaloo