thanos icon indicating copy to clipboard operation
thanos copied to clipboard
verified publisher icon thanos-io

Query: Fixing extended functions in distributed querier

Open pedro-stanaka opened this issue 1 year ago • 3 comments

  • [ ] I added CHANGELOG entry for this change.
  • [ ] Change is not relevant to the end user.

Changes

  • Adding repro case for broken query with distributed engine
  • Fixing problem with distributed queries and xfunctions
  • Adding support for extended functions in tenancy enforcement
  • Moving custom parser to new package

Verification

Added new acceptance tests and tested locally with two queriers.

pedro-stanaka avatar May 03 '24 06:05 pedro-stanaka

LGTM, can you separate the prometheus import from stdlib imports though please?

MichaHoffmann avatar May 03 '24 06:05 MichaHoffmann

LGTM, can you separate the prometheus import from stdlib imports though please?

@MichaHoffmann can you recheck?

pedro-stanaka avatar May 03 '24 07:05 pedro-stanaka

Should we forbid using parser.ParseExpr directly through faillint? What about other places where parser.ParseExpr is used? 🤔

I have a follow up PR where I will clean up all other places where we use parser.ParserExpr did not want to include on this one because I will touch more than 30 files. I can also create this fail lint rule if it is the case.

pedro-stanaka avatar May 03 '24 13:05 pedro-stanaka