Michael Hoffmann

Results 224 comments of Michael Hoffmann

Is the pool returning too small size slices?

how is storage gateway configured?

This is fixed by upgrading to a recent thanos version, Ill close this; please reopen if I missed something!

> The fix itself LGTM but now that we know about this bug, the `Hash` field in `*storepb.Chunk` becomes kind of useless. Perhaps we could add a Hash field to...

Note: e2e tests worked for me previously because i didnt rebuild the docker image.

Could you add an acceptance test please?

Yeah i think this issue can be closed! It can be tested with 0.33.0-rc.0 already

`README.md` changes were automatically created by `make lint`

> Idk what block storage you are using but cortex has s3 with sse... maybe is worth looking at it: > > https://github.com/cortexproject/cortex/blob/master/pkg/storage/bucket/sse_bucket_client.go I wanted to add client side encryption...