Kerbiter

Results 316 comments of Kerbiter

Well I am not sure what path would be the best to take here. The main point is that what's the point of a generated SQL if it can't be...

> "It can't be executed or verified" Correction, I only said that it can't be executed as-is. > It may depend slightly on what RDBMS ...and that's where the problem...

The query below is not executable by any Firebird utility, the `DECLARE` and `SET` syntax is simply not valid here, and named input params specification via `@name` is also not...

> Is it really accurate to say "the query is actually just SQL Server"? because then it would be totally wrong. > I'm guessing the issue is that the _query...

> Also, a question: if all of this is done, even if it is provider specific, does it need a config flag to avoid 'surprises' for people expecting the old...

> Off the top of my head, the biggest problem I see is being able to filter out changes to `bindingList` that are coming from `sourceCache`, to avoid trying to...

@frg2089 you can batch apply all the suggestions if you go to `Files` tab, that way they will be in one commit.

> Sorry, I just noticed this. No problems. > Do you want me to clean up the commit log? No need, we will squash merge anyways.

> Optimally this should be fixed in the spawners. I think it would still be beneficial to have this fix even if it should be fixed on the spawner side....

I don't think there's a whole ton of spawner bugs though? @Belonit do you have this issue fixed already in your spawner reimpl?