Matthew Middlehurst

Results 306 comments of Matthew Middlehurst

You only have to fix the ones in the regression deep learning files, my main concern is that it is capturing other files using these i.e. testing. If there are...

This was a nice experiment but it has gotten a bit overly complex. mypy still does not work very well currently for our codebase it seems especially with complex types....

Interesting to note, maybe worth creating an issue? Out of scope for this PR though yeah

Either solution would work. Whichever is more similar to our pip extras or is more commonly used/recommended by the community I guess.

You do not even need to do that really. Its just to tell others that you are working on it.

This seems incomplete? There are still cases with single ` usage. Some new ones were added by the look of things.

LGTM. Question is still open on whether this is the best way to do this for KNN, but it is much better than nothing.

Hello, is this still active? If so replacing the quotes for strings shouldn't be done. i.e. ``"string"`` would be correct instead of ``string``