Matthew Middlehurst comments

Results 306 comments of


                                            Matthew Middlehurst

[Doc] A fix to inconsistent ticks in Base module

@all-contributors add @Ahmed-Zahran02 for docs

[ENH] add type hints to _shapelet_transform.py init method

Not a blocker, fine with that as is, but is it better to do `int or float` or just `float`? I would say `float` implies integers are also accepted, but...

[DOC] Add Raises to docstrings for methods that can raise exceptions

I would start by reading our contributor guide and joining the Slack channel https://www.aeon-toolkit.org/en/stable/contributing.html. Best way to find these is probably searching what raises errors to start with. A good...

[DOC] Add Raises to docstrings for methods that can raise exceptions

Updated text

[DOC] Add Raises to docstrings for methods that can raise exceptions

I wouldn't assign yourself to this, just create a PR.

[MNT] Add features to issue assign bot

Work on some of your current PRs first please. Also it would not be best to take on all of these at once.

[MNT] Add features to issue assign bot

Please do not do all of the improvements in a single PR.

[ENH] Add test that the estimator "algorithm_type" is valid

It would be a test checking that the value of `algorithm_type` is valid i.e. `distance`, `interval`, `shapelet` etc.

[ENH] Add test that the estimator "algorithm_type" is valid

I wouldn't raise an error for now

[ENH] Add test that the estimator "algorithm_type" is valid

Above is outdated, all estimators should have the tag now. It may have a `None` value for now, however.