Matthew Middlehurst
Matthew Middlehurst
I have closed the other PR, is this still active @tanishy7777?
I still have a few comments above. More concerned with correctness than speed currently but if you can benchmark it thats good.
Thanks. Seems to be a couple of errors currently. Any chance you have some results which show this is comparable in performance to the original?
This would be good to have in but seems abandoned. Maybe we should create a label for inactive PRs which lets people know they can be taken over and closes...
Thank you. I have resolved the above issues and merged it with the other PRs for this file.
Hi, this does not seem to add much that the general testing does not test. It would be better to add any expected results to the `testing/` utilities. Cases which...
Please do no use AI to make changes and write the PR description in this manner. There are a lot of changes we have not asked for. I wont just...
Hi, this is very outdated and has had no response in months. Feel free to try again in a new PR if you want.
I like this in principle, but I have no way to verify its correct currently that isn't too time-consuming given some of them are complex. If you could verify these...
Nah i would ignore that one for now. Could you check the whole module? I am not 100% familiar with mypy but wouldnt `--follow-imports=skip --ignore-missing-imports` stop it from checking other...