MatthewFlamm

Results 333 comments of MatthewFlamm

IMO the biggest hurdle here is not the mypy execution options, i.e. `mypy pyvista` vs. `pre-commit run mypy --all-files`. This could be harmonized between doing `mypy --option1 --option2` or putting...

I'm not trying to argue against some of the proposals here, but I'd focus first on getting the dependencies aligned with typing here and only then adding in more mypy...

> It's a bit annoying to have my dependent projects warn about `extract_surface` not being typed. This might be a slightly separate issue, but very related. Because of our inheritance...

> Strange that I did not notice before, but calling `clean()` on an unstructured grid with just lines already fails. > > ```python > import pyvista as pv > line...

> Thanks, @MatthewFlamm. I was using 3 points to make sure `clean()` was actually doing something. I slightly modified in the test below so that they both have 3 points...

> What about adding this kind of option to global_theme, e.g. pv.global_theme.force_float_points=True by default as a standard config option? I love this idea. Then the setter would follow the theme...

Is this ready for review, I still see some commented code and TODO, but maybe those are left over.

Coming back to this, I have been unsatisfied with `add_ruler` recently due to seeming lack of control of tick label positions. I want to look into whether this can be...

It isn't clear to me that this PR handles this case correctly: https://github.com/pyvista/pyvista/blob/7ae6b9a7e08efebd499b125c93e28b4aa58a064a/examples/00-load/reader.py#L122 But I haven't looked deeply. It seems to me that the logic assumes some coherence in state....

This seems like a good idea, but my experience is that some (many?) VTK readers are not happy with non-string based paths or direct data being passed in binary/string form....