MatthewFlamm
MatthewFlamm
I looked into some of this typing weirdness. I believe that our mypy testing is flawed, so we need to be careful on the types we add. Using [mirrors-mypy](https://github.com/pre-commit/mirrors-mypy), means...
@tkoyama010 I suspect that the caching for the documentation is now broken. Are you able to clear the cache manually or increment the key in some way to invalidate it...
I've had problems in the past with executing multiple clip operations sequentially on a mesh. In some cases, I would get errors related to the number of points for the...
Is the `dims` and `corner` representation common in this space? vtk doesn't accept this, so I suspect that a lot of time is spent generating the data vtk expects. This...
I haven't fully digested your code examples yet, but I'm +1 for making the `__init__` code logic better. > It seems that a lot of time is wasted by numpy.unique...
My opinion is that we should not add these functions. It would be never ending. I would prefer to only have these helper functions that help cut through the mess...
> > Ideally there would be an option to `pip install pyvista[no-vtk]` But optional requirements are additive and not subtractive. > > Exactly. [pypa/setuptools#1139](https://github.com/pypa/setuptools/issues/1139) would make this work, but until...
This approach needs to be compared to and reconciled with #5718. That approach does the comparison after the doc build. This is not fool proof, as the documentation build can...
An alternative API is to follow threshold and allow a sequence to be supplied: ```py isovolume = mesh.clip_scalar(scalars=scalars, value=[vmin, vmax], invert=False,) # scalars within range isovolume = mesh.clip_scalar(scalars=scalars, value=[vmin, vmax],...
> Also, we desperately need better cross-refs between filters. clip_scalar should definitely make reference to threshold and vice-versa in the see also sections. I agree. It would also be useful...