MatthewFlamm

Results 333 comments of MatthewFlamm

There have been no responses either here or in the forum in regards to path forward. If there is not appetite for moving forward with this PR. I can close...

> All I want to do is print as above say once a second, signal.signal( signal.SIGINT ) -> callback -> stop solve_ivp -> return sol as usual. For that, this...

I agree with this. The only question I have is what is the most relevant time, but isn't important for this package.

I think it makes sense to keep them together in some manner. Otherwise we will end up with quite a few attributes added. What about `forecast_metadata` and `forecast_hourly_metadata`? We could...

I'm in favor of making a breaking change to the `NWS` class to return all the information, e.g. `return periods, metadata, ...`. Added: The mental model I had when constructing...

I think this was closed in #214 . Feel free to request it to be reopened if it wasn't.

I personally find running `mypy` through pre-commit to be extremely awkward. This is compounded by the fact that running mypy locally after doing `pip install -r requirements_docs.txt` etc. does not...

I'm not sure whether this vtk reader is relevant here https://vtk.org/doc/nightly/html/classvtkAMReXGridReader.html

I recommend that if this is complex, which it seems it is, we do it in smaller chunks. Otherwise in my experience, it is hard to track down whether a...

I want to make sure that credit is apportioned fairly with these PRs. If this is merged into the branch from #6259, it might seem on first glance as if...