Mathieu Lamiot

Results 242 comments of Mathieu Lamiot

The initial goal of restricting the number of elements searched was to limit resource consumption of the script. Now, it looks like we want to add a lot of element...

https://wp-media.slack.com/archives/C06CQPWEJSK/p1724226102206429

Closing this PR as it is merged in #6929 which will be merged in LRC branch already

👋 @Tabrisrp As part of this PR, maybe you could get the occasion to improve test coverage of the frontend controller. We had a quick fix [here](https://github.com/wp-media/wp-rocket/pull/6880/files) (see Slack https://wp-media.slack.com/archives/CUT7FLHF1/p1724228398435879)....

1st point discussed [here](https://wp-media.slack.com/archives/CUT7FLHF1/p1724850889231899) Pending product confirmation of the expected behavior, and an issue to tackle it.

@piotrbak I think the case where the LRC row contains a status different than "completed" should be added here too. I think currently, if the row is failed, it will...

@jeawhanlee this issue has been moved to In Progress without grooming. I assume because it was possibly a quick fix in the first place? But it has been 4 days...

As mentioned by @Tabrisrp, should be a quick fix by updating AS in composer. @Tabrisrp, should we also update [inc/Engine/Common/Queue/Cleaner.php](https://github.com/wp-media/wp-rocket/pull/6836/files#diff-f6c889f6adbe29567b4fa1770f5f2f36930e3e9b050e1003cf3f12e3fc34b545) (exactly like you did in [this PR](https://github.com/wp-media/wp-rocket/pull/6836/files#diff-f6c889f6adbe29567b4fa1770f5f2f36930e3e9b050e1003cf3f12e3fc34b545))?

About this AC: > Clear performance hints to trigger a warm-up. After a few minutes, LRC data must be available in DB and the rows must contain hashes. There could...

@Miraeld @jeawhanlee - Is the data model [here](https://www.notion.so/wpmedia/Lazy-render-content-bf707b5f731a426cb5d1294beb770540?pvs=4#756b1752a99348f98e84a4bb465181e1) OK? - Is check_data() exactly the same as the one for OCI? - For add_data(), based on the data model, should we:...