Update Action scheduler to 3.8.1 to prevent warning in specific scenario
Before submitting an issue please check that you’ve completed the following steps:
- Made sure you’re on the latest version => 3.16.4
- Used the search feature to ensure that the bug hasn’t been reported before
Describe the bug
When visiting the scheduled actions page after triggering LCP fetch, we will have a warning
[21-Aug-2024 10:18:17 UTC] PHP Warning: A non-numeric value encountered in /var/www/new.rocketlabsqa.ovh/htdocs/wp-content/plugins/wp-rocket/inc/Dependencies/ActionScheduler/classes/ActionScheduler_ListTable.php on line 400
To Reproduce Steps to reproduce the behavior:
- Only WPR installed and activated
- Change permalinks
- Open the scheduled actions page
- Check debug.log and fetched URLs
Expected behavior No warning is displayed in debug.log and fetching works
Additional context
- This is not happening when using the latest AS 3.8.1 plugin with WPR so we need to update AS in WPR
- slack https://wp-media.slack.com/archives/CUT7FLHF1/p1724235857206149?thread_ts=1719475724.930769&cid=CUT7FLHF1
Acceptance Criteria (for WP Media team use only) Clear instructions for developers, to be added before the grooming
As mentioned by @Tabrisrp, should be a quick fix by updating AS in composer. @Tabrisrp, should we also update inc/Engine/Common/Queue/Cleaner.php (exactly like you did in this PR)?
Yes it's necessary to match with the new structure of the parent method
It works fine with me.
I don't have anything in debug.log, it works as expected.
My testing process is reproducing the steps that were used to reproduce the issue here