wp-rocket icon indicating copy to clipboard operation
wp-rocket copied to clipboard

Add control over LCP/ATF elements to backend for support to update

Open DahmaniAdame opened this issue 1 year ago • 1 comments

Is your feature request related to a problem? Please describe.

To reduce what is required to fix new potential LCP elements markup, and to reduce the waiting time for all uses to access the update, we need to add LCP/ATF elements candidates to the backend and be part of the dynamic lists updates.

https://github.com/wp-media/wp-rocket/blob/60749b7f9a7c390bf9de979739dee632575ad585/inc/Engine/Media/AboveTheFold/Frontend/Controller.php#L492-L503

Controlling filter: rocket_atf_elements

Describe the solution you'd like N/A

Describe alternatives you've considered Support currently use helper plugins as a temporary workaround until an update adds the new element.

Additional context Elements need to be confirmed by T2s.

DahmaniAdame avatar Jun 04 '24 06:06 DahmaniAdame

The initial goal of restricting the number of elements searched was to limit resource consumption of the script. Now, it looks like we want to add a lot of element types?

  • If we add from the backend, we won't have a feedback loop to check impact on plugin performance. It is a risk to keep in mind.
  • Why not consider just selecting all elements anyway in that case?

MathieuLamiot avatar Jun 04 '24 07:06 MathieuLamiot