phinx icon indicating copy to clipboard operation
phinx copied to clipboard

Published 20 hours ago • verified publisher icon cakephp

Implement identity in PostgresAdapter

Open ajibarra opened this issue 2 years ago • 6 comments

Working on #2070 . Implementing IDENTITY for column in PostgresAdapter.

ajibarra avatar Apr 08 '22 10:04 ajibarra

@MasterOdin any Chance to get this merged for 0.13? Would be great to have Support in cakephp/Migrations at some point. Thanks a Lot!

swiffer avatar Aug 25 '22 15:08 swiffer

ping @ajibarra

Otherwise @swiffer you could also make a new PR from those changes and include the mentioned feedback Then we can merge an alternative PR here as well.

dereuromark avatar Aug 29 '22 08:08 dereuromark

@MasterOdin changes requested has been pushed. For some reason coverage has decreased. One of the issues reported is because of splitting the exception message to avoid PHP CS warning but I can't find the actual reason for the other one (L105-L106) because connect method is called for sure and that lines are executed so I am out of ideas.

ajibarra avatar Sep 01 '22 11:09 ajibarra

@MasterOdin changes requested has been pushed. For some reason coverage has decreased. One of the issues reported is because of splitting the exception message to avoid PHP CS warning but I can't find the actual reason for the other one (L105-L106) because connect method is called for sure and that lines are executed so I am out of ideas.

@dereuromark Maybe you know?

ajibarra avatar Sep 16 '22 05:09 ajibarra

The decrease in code coverage is fine. Most likely some of the formatting changes made here touch upon code that's not tested.

MasterOdin avatar Sep 16 '22 05:09 MasterOdin

The decrease in code coverage is fine. Most likely some of the formatting changes made here touch upon code that's not tested.

Great then, so it is ready to be merged after approval. Thank you @MasterOdin

ajibarra avatar Sep 16 '22 05:09 ajibarra