Martin Hjelmare

Results 293 comments of Martin Hjelmare

The dev docs PR wasn't linked in the description. I added it.

This doesn't fix anything on its own. We can't categorize it as a fix.

This comment isn't addressed: https://github.com/home-assistant/core/pull/123945#discussion_r1860525591

It doesn't really need a PR to the library, I believe. The data is already available in `TibberHome.info`. Although one could argue that the library exposes other data more explicitly....

We also need to check the update frequency of the requests after the change. We shouldn't do more requests per time unit than before.

I don't understand the test failure. The test looks ok to me.

Why did it matter to move the patch of sys.exit?

Right. Do we still need to patch it then?