Add price for energy and tax as state attribute to Tibber price sensor

[GraceGRD]

Proposed change

Expose additional information such as energy price (excluding tax) and the amount of tax. In my situation I would like to control/limit my solar inverter power based on the energy price excluding tax.

I added these values as state attribute to the energy price sensor (including tax) however I'm not sure what the best place is to implement this change (as state attribute or a separate sensor excluding tax). I would like to have your opinion, so I marked this PR as draft.

Type of change

• [ ] Dependency upgrade
• [ ] Bugfix (non-breaking change which fixes an issue)
• [ ] New integration (thank you!)
• [x] New feature (which adds functionality to an existing integration)
• [ ] Deprecation (breaking change to happen in the future)
• [ ] Breaking change (fix/feature causing existing functionality to break)
• [ ] Code quality improvements to existing code or addition of tests

Additional information

• This PR fixes or closes issue: fixes #
• This PR is related to issue:
• Link to documentation pull request:

Checklist

• [ ] The code change is tested and works locally.
• [ ] Local tests pass. Your PR cannot be merged unless tests pass
• [ ] There is no commented out code in this PR.
• [ ] I have followed the development checklist
• [ ] I have followed the perfect PR recommendations
• [ ] The code has been formatted using Ruff (ruff format homeassistant tests)
• [ ] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• [ ] Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• [ ] The manifest file has all fields filled out correctly.
  Updated and included derived files by running: python3 -m script.hassfest.
• [ ] New or updated dependencies have been added to requirements_all.txt.
  Updated by running python3 -m script.gen_requirements_all.
• [ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

• [ ] I have reviewed two other open pull requests in this repository.

[home-assistant[bot]]

Hey there @danielhiversen, mind taking a look at this pull request as it has been labeled with an integration (tibber) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of tibber can trigger bot actions by commenting:

• @home-assistant close Closes the pull request.
• @home-assistant rename Awesome new title Renames the pull request.
• @home-assistant reopen Reopen the pull request.
• @home-assistant unassign tibber Removes the current integration label and assignees on the pull request, add the integration domain after the command.
• @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
• @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

[emontnemery]

@GraceGRD Please click the "Ready for review" button if you want the PR to be reviewed again

[GraceGRD]

@GraceGRD Please click the "Ready for review" button if you want the PR to be reviewed again

Thanks for the suggestion. I'm having difficulty finding some free time lately. Build is also not passing, will try to fix that first. 😁

[GraceGRD]

Marked as ready for review, I'm unable to resolve the codecov/patch check and I need some help here.

[gjohansson-ST]

Is this the same as the other entity except it is the price without tax? I don't see why we should add this in that case as it would be quite easy for a user (you) to use the existing one in a template to remove VAT.

[GraceGRD]

Yes,

No other Tibber entities or entity attributes provide the amount of tax to my knowledge. Please point me to it if this exists. My first idea was to add this as a state attribute so that I can use a template sensor to get this number. Then you suggested to make this as entities, so I did.

My use case is as follows: Energy price incl vat negative -> Turn off the solar inverter Energy price exc vat negative -> Regulate solar inverter to stop exporting energy (only for self consumption) Other cases allow solar inverter to export all energy.

I know there are other sources to get energy prices/tax etc. however I would like to obtain these values from the source, so I now they are true and accurate. Similarly these prices are provided by the Tibber app.

[home-assistant[bot]]

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks :+1:

Learn more about our pull request process.

[MartinHjelmare]

This comment isn't addressed: https://github.com/home-assistant/core/pull/123945#discussion_r1860525591

[GraceGRD]

Hmm okay, I'll make a PR on pytibber with the required changes, then create a PR on dependency bump an then address the issue.

[MartinHjelmare]

It doesn't really need a PR to the library, I believe. The data is already available in TibberHome.info. Although one could argue that the library exposes other data more explicitly.

What we need to do is use a DataUpdateCoordinator here in the integration to get the data and then subscribe both entities to the coordinator updates.

[GraceGRD]

Tibber does have a coordinator.py already. I'll try to change that one. So far all my attempts have failed. :(

[MartinHjelmare]

We also need to check the update frequency of the requests after the change. We shouldn't do more requests per time unit than before.

[GraceGRD]

Please let me know if this change is even welcome. I get the idea that it is not... If so I'll stop putting effort in it and close the PR.

[gjohansson-ST]

Please let me know if this change is even welcome. I get the idea that it is not... If so I'll stop putting effort in it and close the PR.

It's a welcome addition, otherwise we would have said so. We just need it to do the right things and sometimes that also means one has to refactor code which was already present 👍

[GraceGRD]

Ok thanks for clearing that up.

I did some testing with the current state of the application and I found some gaps in the sensor data for the price-ex-tax sensor. . Not sure why this happens, could be that I'm running this on my development laptop. However the price sensor does not have this issue.

No real clues in the log except for lots of took 0.xxx seconds warnings: /home/vscode/.local/ha-venv/lib/python3.12/site-packages/aiohttp/web_protocol.py:559> took 0.188 seconds

[github-actions[bot]]

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. If you are the author of this PR, please leave a comment if you want to keep it open. Also, please rebase your PR onto the latest dev branch to ensure that it's up to date with the latest changes. Thank you for your contribution!