Martin Hjelmare

Results 277 comments of Martin Hjelmare

I think it's nice since it will help integrations to do the right thing. I think there are many integrations that have reauth flows where they don't check that the...

If possible, please make a PR with a fix to pyTibber if there's a bug there.

It's enough if you've tested locally with the fix in pyTibber that this PR works.

I don't maintain pyTibber so I can't cut a new release there on my own. Daniel maintains that library.

We normally don't add a util until there are at least two existing places that needs it. Until then we can just copy the suggested code here and use where...

Let's keep this PR in draft until there are two places that need it. We don't need to close it.

I think this can wait until the November release since to be useful it requires frontend changes anyway, which may not all be ready.

Can be merged when there's a linked approved frontend PR that uses the new command(s).

> Use the SPDX license identifier for GPL-2.0-or-later We use Apache 2.0.

How compatible is this with our current license validation in Home Assistant core? I know there was some work done already to replace the text variable with classifiers in 3rd...