Martin Hjelmare

Results 339 comments of Martin Hjelmare

The `requirements.txt` file is only used for development. That can be pinned. It's the requirements required for production that should be pinned as forgiving as possible. There are no limits...

I think we need some dev docs too, or maybe just user docs?

And a frontend PR for the websockets commands.

In the link step, add a check if the client attribute is None. If so create the client and store it in the client attribute.

There's a mypy failure that we need to solve too. ``` Run . venv/bin/activate Python 3.11.8 Error: venv/lib/python3.11/site-packages/tenacity/tornadoweb.py:23: error: Cannot find implementation or library stub for module named "tornado.gen" [import-not-found]...

I think we need to add `ignore_missing_imports` for `tenacity` in mypy.ini via mypy config. I'll look at that separately.

No need to merge dev branch regularly unless we know we need something from it.

We think the problem is that python telegram bot no longer implicitly requires tornado which makes mypy fail to find that import in tenacity, which is a 3rd party requirement...

Working on trying to reproduce the mypy failure.

There are multiple integrations that require tenacity. This is already known. I've been trying to reproduce the issue so I can confirm that my fix works. I'll try to downgrade...