Martin Hjelmare

Results 339 comments of Martin Hjelmare

We should update the docs about supported version too. https://www.home-assistant.io/integrations/glances/

I think it's ok to wait until the February release. Users may see the warning in the log and that's ok, I think.

Please avoid making "a little bit of everything" PRs. Create one PR for each type of change.

Please adjust the PR title to the latest changes. Start with a verb in imperative mood.

The cover platform is already covered by existing tests. It's enough to check that the expected state is created in the state machine and that the expected entity is enabled/disabled...

Is the Nuki ID a serial number? Why is it referred to as Nuki ID instead of serial number?

Ok, thanks for clarifying. 👍

Please update the breaking change paragraph with what users should do to avoid breakage when the attributes are removed. Ie, update any automations and scripts that use the concerned state...

Ping me when done, and I'll merge.

I think you may need to rebase your branch on latest dev branch.