Martin Hjelmare

Results 339 comments of Martin Hjelmare

There's still only a placeholder page for controller requirements, without content.

It feels like I'm repeating myself somewhat in the code review. Eg you still don't seem to have run the scaffold script to see our best practice code examples. You...

Please link a docs PR that adds the new sensor to the list of supported sensors. https://www.home-assistant.io/integrations/apcupsd/#sensors

Please solve the merge conflict.

> Should we consider inheriting `RestoreSensor` for the sensors as currently a restart would change the state to `unknown` until a new push comes in. Sounds ok.

Please solve the merge conflict.

Please address the comments in a new PR. Thanks!

In Home Assistant, for now, we treat sensors that report V_TRIPPED as binary sensors with state. We don't specifically support push buttons although S_SCENE_CONTROLLER + V_SCENE_ON can be used for...

It would probably involve adding a new S type and one to many V types for the different push events. Probably at least two different push events, click and hold...