core
core copied to clipboard
Bump bring-api to 0.3.0
Proposed change
Updates the bring-api library from 0.1.1 to 0.3.0.
The library has been refactored for PEP8 compliance and methods have been renamed to snake_case.
Release notes bring-api 0.3.0 Changelog bring-api 0.1.1...0.3.0
Type of change
- [x] Dependency upgrade
- [ ] Bugfix (non-breaking change which fixes an issue)
- [ ] New integration (thank you!)
- [ ] New feature (which adds functionality to an existing integration)
- [ ] Deprecation (breaking change to happen in the future)
- [ ] Breaking change (fix/feature causing existing functionality to break)
- [ ] Code quality improvements to existing code or addition of tests
Additional information
- This PR fixes or closes issue: fixes #
- This PR is related to issue:
- Link to documentation pull request:
Checklist
- [x] The code change is tested and works locally.
- [x] Local tests pass. Your PR cannot be merged unless tests pass
- [x] There is no commented out code in this PR.
- [x] I have followed the development checklist
- [x] I have followed the perfect PR recommendations
- [x] The code has been formatted using Ruff (
ruff format homeassistant tests) - [ ] Tests have been added to verify that the new code works.
If user exposed functionality or configuration variables are added/changed:
- [ ] Documentation added/updated for www.home-assistant.io
If the code communicates with devices, web services, or third-party tools:
- [x] The manifest file has all fields filled out correctly.
Updated and included derived files by running:python3 -m script.hassfest. - [x] New or updated dependencies have been added to
requirements_all.txt.
Updated by runningpython3 -m script.gen_requirements_all. - [x] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
- [ ] Untested files have been added to
.coveragerc.
To help with the load of incoming pull requests:
- [ ] I have reviewed two other open pull requests in this repository.
Hey there @miaucl, mind taking a look at this pull request as it has been labeled with an integration (bring) you are listed as a code owner for? Thanks!
Code owner commands
Code owners of bring can trigger bot actions by commenting:
@home-assistant closeCloses the pull request.@home-assistant rename Awesome new titleRenames the pull request.@home-assistant reopenReopen the pull request.@home-assistant unassign bringRemoves the current integration label and assignees on the pull request, add the integration domain after the command.@home-assistant add-label needs-more-informationAdd a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.@home-assistant remove-label needs-more-informationRemove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks :+1:
Please don't pin dependencies like aiohttp to a version
@joostlek What do you mean? In the package definition on pypi?
In the requirements in requirements.txt.
In the requirements in requirements.txt.
Does that only count for aiohttp or what other libs does that apply to? Putting constraints on libs will still be necessary, but only on mahjor level.
We will reduce the requirements👍
The requirements.txt file is only used for development. That can be pinned. It's the requirements required for production that should be pinned as forgiving as possible. There are no limits there currently.
https://github.com/miaucl/bring-api/blob/fe007ce1abfb3765b9a8a27eab5ce8f2576ecc8d/setup.cfg#L19-L20
Ooohhh, I now remember i made this mistake before. I already tried searching for this list but couldn't find it
Ooohhh, I now remember i made this mistake before. I already tried searching for this list but couldn't find it
That is what I meant with the pypi😅
In the setup.cfg is the list for prod @joostlek
Ah right, my mistake, sorry!
Is there anything more we have to change?