Manish Goregaokar

Results 1095 comments of Manish Goregaokar
trafficstars

Oh, just use `warn!()` or probably `error!()` from the log crate, we already use it in the codebase, e.g. https://github.com/servo/media/blob/220ed1388f2ba008b05f5e94aca21dd14aa37290/backends/gstreamer/lib.rs#L162

So it: - works on @jdm's Mac - does not work on @ferjm's Mac - does not work on my 20.04 Ubuntu system that has latest gstreamer - does work...

Yep, that's what `create_audiostream` and `create_videostream` do for gstreamer :) However we'd need to internally capsfilter them.

https://github.com/servo/media/pull/262 added some mocking support, however it doesn't take the capsfilter into account (yet)

We should fix the code to match the test here, usually such bugs (when WPT disagrees with the spec) are spec bugs, and it makes sense for that to be...

@bors-servo retry

@bors-servo clean r- retry

@bors-servo retry

@bors-servo r- r+ retry clean

This is a symptom of other bugs (e.g. the try bug), or when you synchronize on a restart while there are existing builds.