Manish Goregaokar comments

Results 1183 comments of


                                            Manish Goregaokar

Better document key selection

@robertbastian it can't do it based on the JS apis actually being called, no?

Better document key selection

> Doing this in JS is possible, but it requires a few extra steps: first you need to DCE your Diplomat-generated JS code, then you need to rebuild the WASM...

Better document key selection

My current position is that we should: - Document what keys are in power user documentation - Document how to manually find out the needed keys for a call (including...

Bridge the gap between `icu::properties::Script` and `icu::locale::subtags::Script`

I think "conversion with caveats" might be fine. Yes, they represent different things.

Bridge the gap between `icu::properties::Script` and `icu::locale::subtags::Script`

Separately from the discussion of performance, I do think these are _two different kinds of things_ and I would overall prefer us to have an explicit separation of types even...

Bridge the gap between `icu::properties::Script` and `icu::locale::subtags::Script`

I generally agree. I'm not really sure I can see any way a third type would make sense, but I think having the split is somewhat valuable, provided it's easy...

Units formatting Data Skeleton Design

Is this still a 2.0 blocker?

Allow ULEs to be bit-packed rather than byte-packed

I'm fine with a new type, strongly against making this change to ZeroVec itself since it would trade off performance for size in a much stronger way. We could even...

Add Unicode Blocks access and iteration

One note is that we should document that unassigned code points may still report being in a block: which is not necessarily the behavior of all APIs I have seen...

Writeable LengthHint should be called LengthBound

I think it should stay a hint, and we add that guidance yes.