Manish Goregaokar

Results 1183 comments of Manish Goregaokar

But it seems like that just hoists all the definitions to the outer scope? So they'll clash with each other?

This should work: https://github.com/yaahc/displaydoc/pull/49

@kpreid hmm, in that case the error message for this future incompat lint seems incorrect? https://github.com/rust-lang/rust/issues/120363#issuecomment-2177064702

The nightly build is broken right now due to the libtest changes, and we can't fix that without breaking the stable build.

No, rustc's libtest changed, we can't roll that back. It's part of a larger set of changes; @gnzlbg is working on it.

The fix is to use the libtest crate, however that crate doesn't work on stable right now, so we can't upgrade to use it.

#162 doesn't matter, we yanked that release 0.3.19 was broken on nightly prior to that being merged, I opened #162 to fix it, but the fix was broken. > Oh,...

I think that might be fine, I'm not sure what the best way is (and this crate is not actively maintained). Hope it works!

Oh, I remember now. I wonder what issue red-green is having then.

No strong opinion really.