Manish Goregaokar

The plan is: - CalendarArithmetic takes in a `&PrecomputedData` type parameter on all of its methods. Most calendars use `()` https://github.com/unicode-org/icu4x/pull/4378 - ArithmeticDate contains a `YearInfo` field which also defaults...

Discussed a bit with @sffc: In general we think that YearInfo and PrecomputedData will not need to differ on the data stored per-year (they may differ on the data storage...

ugh, found some gnarly stuff that will not be easy to optimize https://github.com/unicode-org/icu4x/blob/c755786f6482daf0fb277ffdad001a53950082b3/components/calendar/src/chinese.rs#L311 This needs the number of days in the _previous_ year. We might just also cache that but...

@sffc We need to make a decision based on the [benchmarking results](https://github.com/unicode-org/icu4x/pull/4504#issuecomment-1874721841): > Consider adding a new() and deprecating new_calculating() (and the try_new...with_calendar(), if we are definitely not precomputing (otherwise...

All dates (in range, which is a range of ~i32 years I think: check the code) Prior versions of the Hebrew calendar used slightly different four gates tables, Adjler documents...

I've started working on the islamic ones. My current data model is to store month length booleans and then use the remaining 4 bits to store a new years offset...

I think what we should do for these is that we have the macro generate `cfg_attr(not(internal_docs), doc(hidden))` and generate our internal docs with `RUSTFLAGS=--cfg internal_docs`. We shouldn't use a cargo...

Concrete proposal: - We have a macro - It marks things as doc(hidden) except in `cfg(icu4x_internal_docs)` mode - ICU4X docs-gen has that CFG set - (optional) there's a nice "unstable...

Cross posting from https://github.com/unicode-org/icu4x/pull/5101#issuecomment-2186931612: My opinion on this shifts if we plan to put unsafe code in `icu4x_shared`: i'd rather we used a separate crate since it seems suboptimal for...

This was a deliberate choice so as not to overcommit to the implementation of the iterator, especially since we are returning adapters. We can write explicit adapters, however: - we...