Manish Goregaokar

Results 1204 comments of Manish Goregaokar

> **Do we need the ability to pass in a default level to ICU4XBidiInfo?** Also, this part is already done.

> The input is the position of the character not the character itself. Yes, that's how it works in ICU, no?

Right, that's what we do in the code too

Yeah, that's what I was referring to as "index maps" earlier. I think we should be fine to add them, but it should be a decent API. We might want...

@sffc we still need some kind of intermediate API exposed from unicode_bidi for this, yes? any idea what it should look like?

ah, i see. wouldn't that involve querying the bidi data over ffi in a loop, though? might have perf issues.

Right, but we still need lower level APIs that produce those level maps, yes?

Though it's possible that's already exposed by unicode-bidi by virtue of most fields being public

Ah, I imagined that they got it from ubidi apis

Ah, I was under the impression Younies had done that too (from his comment) and I just hadn't seen the PR. Should have looked closer at the PR link!