Manish Goregaokar

Results 1094 comments of Manish Goregaokar
trafficstars

I think so yeah. We should make sure it's easy to turn on the sanitizers and document both these options prominently

Perhaps raise a warning when asan isn't enabled for a couple releases so people know what's going on?

This also works for me; a slight worry i have is that the instrumented stdlib will slow down fuzzing itself, but I suspect it's not _too_ bad.

In general I think we add generally useful rustc options as separate flags so they're more prominent in `--help` and such

We need to be able to make this take a `--manifest-path` argument. And give a better error message here.

Uh, yeah, please add further owners to the crate. (Me, nagisa, frewsxcv)

This also lets us do things like add custom formatters to libFuzzer (https://github.com/rust-fuzz/libfuzzer-sys/issues/47), because last I checked we can't hook into [any of the optional functions](https://github.com/rust-fuzz/libfuzzer-sys/blob/4ad88ec54fa2e7a0c877b6477cc86ea0de14a90d/libfuzzer/FuzzerExtFunctions.def#L16) That said, it seems...

Something like that, yeah

This looks pretty nice. One of my plans for libfuzzer was to patch the cpp code so that instead of the weird linkage dance, you just call `start_fuzz(settings)` from your...

cc @fitzgen we should make sure this fits in with our plans as well