Manish Goregaokar

Results 1179 comments of Manish Goregaokar

So in general my worry here is that Rust really doesn't have a story for doing _warnings_ in proc macros, and producing an error for what _really should be a...

@sffc thoughts on the above? In general I'm not really in favor of the lower level API having janky warnings-as-errors since someone using the lower level API probably already knows...

> I see no substantive difference between warnings and errors that can be suppressed This is not an error that can be suppressed at a global level, it has to...

Nope. Clippy has plans for this but it's a lot of work, and most likely would not be something a library can impose on clients anyway. That said, you could...

Correct, but you need to be able to justify the existence of such a lint to other clippy maintainers, and as a primary maintainer of zerovec and clippy I'd probably...

The owned type for `Cow` for these types should already be `Box` (except for `str`). I don't really see a huge benefit to (2), and we already have workarounds for...

Actually, I'm a bit confused as to the use case: where are we even putting `VarULE` types in a `Cow`?

I basically don't think this makes sense in the `zerovec` universe. It may make sense in the ICU4X universe because avoiding the Cow problem is something that crops up often...

Yeah, I see. I think optimizing this is an ICU4X concern, not a zerovec concern. I really don't think this fits into the holistic design that well, it's just a...

> It's a zerovec concern to create `ZeroVec` >... > It's a zerovec concern to create `VarZeroVec` ... barely. I actually think in retrospect trying to design this crate to...