Luca Cominardi
Luca Cominardi
LGTM Could you please include in this PR the removal of outdated information in `DEFAULT_CONFIG`? https://github.com/eclipse-zenoh/zenoh/blob/e263d80a076b6f7c4903e7b8952358c7248a5519/DEFAULT_CONFIG.json5#L302
I think the *workflow* should be added to `eclipse-zenoh/ci` instead of `eclipse-zenoh/zenoh`. @fuzzypixelz ?
This PR is not ready yet to be merged and a pre-release is not planned. In the meanwhile, we will be very glad if you could test this PR and...
The problem is more rooted in Rust and cargo as it seems and it's not only specific to Zenoh. Bumping the Rust MSRV would work for Zenoh this time, but...
Closing as outdated. Feel free to re-open it in case it is still relevant.
The very reason for the `write` method to exist is a niche case of `Stream`-like interface where a subscriber can be piped into a subscriber. The very existence of `write`...
Again, my point is that method does NOT exist and it makes the API asymmetrical. This an API whose sole reason to exist is for some Rust ergonomics. I tend...
Write accepts a `SampleKind` and a `Value`, which is a duplication of already existing `put` and `delete` operations on the publisher. Is there any real usage for that or is...
It LGTM. However, given the recent discussion on `Sample` and `SourceInfo` I'd like to have the feedback also from @p-avital and @milyin .
Holding on in merging this PR since it will break the memory layout for zenoh-c and zenoh-cpp at least. Sister PRs in zenoh-c and zenoh-cpp should be done pointing to...