Luca Cominardi

Results 160 comments of Luca Cominardi

Linked issue: https://github.com/eclipse-zenoh/zenoh/issues/709

I think the proposal makes sense. +1

LGTM. However before merging it would be good a list of expected sister PRs in backends/plugins/bindings in such a way we can merge them back-to-back across all the repos.

I'm not sure about that... a plugin gets a `Runtime` from which a `Session` is created at startup and I believe it should keep it around for the whole lifetime....

@Charles-Schleich could you please resolve the merge conflicts?

I manage to reproduce the test failure quite consistently while doing code coverage with: ```sh cargo llvm-cov --test interceptors ``` Output: ```sh running 3 tests test downsampling_config_error_wrong_strategy - should panic...

> I would like to add a protobuf encoding directly to zenoh, because I imagine that's a fairly common used format, but there is no normalized content-type for it. See...

We can't support all types nor be limited to only registered types. Moreover, *vendor* media types are kind out-of-scope in the sense they could be whatever... `application/protobuf` was the proposal...

To guarantee the correct behaviour of Zenoh and avoid API misusage/abuse we should not expose the possibility of generate timestamp for *foreign* ids. The role of `ZenohId` in the timestamp...