zenoh Expose Quality of Service settings (Priority, Congestion Control, Express) the Sample was published with

Expose Quality of Service settings (Priority, Congestion Control, Express flag) the sample was sent with (closes #694)

Feb 09 '24 17:02 DenisBiryukov91

It LGTM. However, given the recent discussion on Sample and SourceInfo I'd like to have the feedback also from @p-avital and @milyin .

Feb 14 '24 10:02 Mallets

Holding on in merging this PR since it will break the memory layout for zenoh-c and zenoh-cpp at least. Sister PRs in zenoh-c and zenoh-cpp should be done pointing to this PR.

Feb 15 '24 09:02 Mallets

@Mallets @OlivierHecart can you consider my proposal above of moving Sample to an accessor pattern?

I think the proposal is in principle ok. The question is: should this PR be blocked by the proposal or should we merge it while we rework Sample entirely? I'm more in favour to get it in alongside the sister PRs so as to unblock some work being done in https://github.com/eclipse-uprotocol/up-client-zenoh-rust/pull/2.

Feb 16 '24 13:02 Mallets

I'm fine with either, but I'd like at least Qos to come out with the accessor+builder API from the get-go.

Keep in mind that if we unblock them with a first branch, they'll have to deal with the breaking change immediately after.

Feb 16 '24 13:02 p-avital

I'm fine with either, but I'd like at least Qos to come out with the accessor+builder API from the get-go.

Keep in mind that if we unblock them with a first branch, they'll have to deal with the breaking change immediately after.

I'm fine with your proposal for Rust.

Similar PRs are available in:

C https://github.com/eclipse-zenoh/zenoh-c/pull/244 https://github.com/eclipse-zenoh/zenoh-pico/pull/348
C++ https://github.com/eclipse-zenoh/zenoh-cpp/pull/99 Let's be consistent as well with other bindings. Should we have some kind of accessors also in C and C++?

Feb 16 '24 14:02 Mallets