Jake Potrebic

Set it to something that doesn’t consume the ingredients. I basically changed all trades to diamond for a dirt. Put in emeralds, and shift clicking out didn’t work.

This is why custom enchants like this should be done via the PDC and Lore with the enchantment plugin providing it's own API to access those "enchants". You can control...

I think this is "Works as Intended". > Called when a player is firing a bow and the server is choosing an arrow to use. is the exact description of...

I think a solid fix for this is to add a boolean to the event on whether this is just a check if the player can use the bow or...

I really think that this PR is over engineered for what we need. I don’t understand why we need to replicate the registry layers, especially when 2 of them really...

You don’t have to remove a distinction between static and worldgen registries, just have two methods in the bootstrap interface to modify them. Removes a ton of unneeded complexity imo....

@InkerBot you sure about that? We changed the hash code and equals of NamespacedKey so it would work with KeyImpl.

It'd help if I actually pushed from my local repo...

The material enum is most likely being deprecated either for 1.20 or the next major update, not really worth it. Even so, I don't really think the order of fields...

Addressed requested changes