Fix global sound event gamerule not being respected

[Machine-Maker]

Changes handling of the global sounds. Previously the global sound gamerule wasn't used correctly resulting in unexpected behavior (fixes https://github.com/PaperMC/Paper/issues/8726). This changes the spigot.yml behavior of setting the sound radius for the 3 events to 0. Now, if set to 0, the default radius is used (64). The behavior is now controlled by the gamerule, only using the configuration for the actual radius, not whether to enable it or not.

---

Download the paperclip jar for this pull request: paper-8727.zip

[kennytv]

I feel like this should go into 0101 and be called "Fix Spigot's global sound handling" now (mfw didn't even see Noah's comment)

[Machine-Maker]

Addressed requested changes

[kennytv]

Should the config really just be ignored if the gamerule isn't set to false? Imo having a config value > 0 definitely means you want this to be used and the sounds to not be global

[Machine-Maker]

Should the config really just be ignored if the gamerule isn't set to false? Imo having a config value > 0 definitely means you want this to be used and the sounds to not be global

maybe we add a migration then which enables initially sets the gamerule if the config is above 0. But we should defer to the “vanilla setting” first. Then look at the spigot config.

[Netherwhal]

What is the current way forward? Ideally we should prefer vanilla behavior?

[Machine-Maker]

Rebased for 1.20.1