Jake Potrebic

> The existing minecraft.commandblock permission only allows you to edit command blocks. It looks like it was meant to also allow for breaking/placing command blocks, but in it's current state...

> Maybe a function on Player that just sends the packets? There's plenty of other API features that make client-side changes. Something like Player::sendOperatorStatus? Not sure what the best name...

Ok, so when a villager's level changes in vanilla, a method called "updateTrades" is called which recalculates the trades based on the new level. Question is, should the API do...

> this is how setType has always worked, why is it considered a bug yeah, I didn’t think it was, but since there is a spigot bug report for it,...

Ok great, then adding a new method is the way to go. The old methods already default to false for that Boolean argument, so should be all good. Just concerned...

So... you know how it's always been this way? Well spigot just changed the behavior to wipe the tile entity when using Block#seType. Unsure if this is even needed then...

Yeah, there’s an open PR to fix this. The current method will be deprecated and replaced because items can be in multiple categories now.

I'd maybe keep the the first line of the javadoc there.

I think this won’t work for some inventory actions. Like shift clicking? Just mutating the stack object isn’t enough for that.

@fr3qu3ncy-dev shift clicking did not work at all. I set the trade to a custom trade in PlayerTradeEvent, shift-clicked the result slot to move the result into my inventory, and...