Benjamin Maxwell
Benjamin Maxwell
Your commit message is too long (it's a maximum of 72 character per line), and the first word after the `:` should be uppercase.
Looks like UBSAN is not happy with this changes: ``` /home/vsts/work/1/s/Meta/Lagom/../../AK/DistinctNumeric.h:268:23: runtime error: signed integer overflow: -2147483648 + -50 cannot be represented in type 'int' #0 0x7ff546379b4c in AK::DistinctNumeric::operator+=(AK::DistinctNumeric const&)...
One option would be not to use a Gfx::Rect and make something like this (below) when computing the overflow clip, since I guess it's not really a rectangle. ```c++ template...
Looks very cool! I think the main little thing that bugs me (:sweat_smile:), is that edges with the same colours are not merged, which leads to visible seams: ![Screenshot from...
I think the simplest solution is only split the border paths when the colours differ (in which case it's not really noticeable). Getting joins to perfectly line up otherwise is...
@zhiyuang You've not really done my suggestion, while you're making one `fill_path()` call you're not actually merging the paths into one border. The path you sending is still split into...
That's awesome! I didn't think of that, but yep it should cancel out with an even-odd fill. Looks great now! 👍
I'll have a proper look over the code soon, but love the result now 😁
You have quite a few fixup commits that need to be squashed
You should probably squash all these commits into one (since they're all part of the same change). And the naming should probably be something like `LibWeb: More correctly paint joins...