serenity icon indicating copy to clipboard operation
serenity copied to clipboard

PixelPaint/TextTool: update TextTool m_font_label from deprecatedS to…

Open HyflerSD opened this issue 2 years ago • 5 comments

Contributes to: #17128

HyflerSD avatar Jun 11 '23 16:06 HyflerSD

Hello!

One or more of the commit messages in this PR do not match the SerenityOS code submission policy, please check the lint_commits CI job for more details on which commits were flagged and why. Please do not close this PR and open another, instead modify your commit message(s) with git commit --amend and force push those changes to update this PR.

BuggieBot avatar Jun 11 '23 16:06 BuggieBot

Your commit message is too long (it's a maximum of 72 character per line), and the first word after the : should be uppercase.

MacDue avatar Jun 11 '23 16:06 MacDue

I just checked Font::human_readable_name returns a DeprecatedString, so this essentially hides the fact that we are using a DeprecatedString here

Sorry that I did not realize it on Discord

Hendiadyoin1 avatar Jun 11 '23 16:06 Hendiadyoin1

I just checked Font::human_readable_name returns a DeprecatedString, so this essentially hides the fact that we are using a DeprecatedString here

Sorry that I did not realize it on Discord

Thanks for the comment, do you have any suggestions on this? Since 'Font::human_readable_name returns a DeprecatedString' should I take a look at that function so we're not hiding?

HyflerSD avatar Jun 11 '23 17:06 HyflerSD

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions!

stale[bot] avatar Jul 03 '23 00:07 stale[bot]

This pull request has been closed because it has not had recent activity. Feel free to re-open if you wish to still contribute these changes. Thank you for your contributions!

stale[bot] avatar Jul 10 '23 22:07 stale[bot]