Benjamin Maxwell
Benjamin Maxwell
(This also no longer requires #14687)
So people can actually see what this is, here's the video in question: https://user-images.githubusercontent.com/11597044/190900891-d9e5723f-f069-4cbd-be32-54108bd4edc0.mp4
There is an implementation of exactly that done for the HTML CRC2D, it can probably be moved to some more reusable helper.
See: https://github.com/SerenityOS/serenity/blob/master/Userland/Libraries/LibWeb/HTML/Canvas/CanvasPathClipper.h (looks like it only depends on LibGfx, so could just be moved there already :))
The commit linked was never merged (it's still only on the [improve-remove-optional-empty-fields](https://github.com/mobilityhouse/ocpp/compare/improve-remove-optional-empty-fields) branch, it seems)
You should squash your new fixup commit into your previous commit :)
SGTM now :+1: (though a maintainer will need to do the merge)
A simpler way to trick the terminal is to create any job in the shell, then disown that job. The job will still appear as a child of the shell,...
So to have that `...` be accurate all the time you can't look at child processes (since some them may be disowned), you need a mechanism for the terminal to...
It shouldn't, it only looks at the children of the shell progress or if there's a foreground process that not the shell. If I just start up a terminal there's...