Benjamin Maxwell
Benjamin Maxwell
(the constructor of cpr::Buffer changed a bit since this PR, the name now has to be a std::string like: ``cpr::Buffer(data, data + m.buffer.length, std::string(m.name));``)
I think it's possible to be done without requiring you to call any additional functions on the class/instance, for example, in Python 3.8+ you could make an optional-aware asdict that...
```py def old_get_origin(type): return getattr(type, '__origin__', None) def old_get_args(type): return getattr(type, '__args__', None) def is_optional(field): # typing.Optional[x] is an alias for typing.Union[x, None] # get_origin/get_args with fallbacks for pre-python 3.8...
The change is still needed for Python 3.7
Not this mod exactly but you may find these videos interesting (they explain how these kinds of portals generally work in games -- they're both great videos & are fairly...
Also, when adding a new feature it's better to add a little video clip or screenshot to your PR than try to describe it.
(This now has conflicts)
If you've not post this in `#code-review` again to try to get some maintainers eyes on it. It's easy for PRs to get lost after a while.
@oirom of course you can, just try to solve the issue and make a PR once you're ready :^)
@m-bilal-ahmed I've not worked in this area but I'd start in something like `Userland/Libraries/LibGUI/TextEditor.cpp` and work backwards from there.