Caleb Beard comments

Results 32 comments of


                                            Caleb Beard

Ensure a sensible timeout for pgsql commands

@edevil Have you been able to look at implementing @dmurphy18 's suggestion?

add namespace to http_json external pillar method

There have been some modifications in this file which has led to conflicts, so could you rebase against those @ctramnitz? Also, a simple unit test for this will help it...

Fix pkg.version_cmp on openEuler

Hi @raulillo82, thanks for the contribution. We will need tests for this in order to get it merged.

Fix pkg.version_cmp on openEuler

@raulillo82 It seems there is some debate about whether this is the correct fix or if openEuler should be added to the RHEL family. I don't know enough about openEuler,...

Add OpenStack metadata grains module

@zmingee have you been able to circle back to this one?

Fix OS grain inconsistencies if lsb-release is installed or not

re-run all

fix returners.postgres inability to handle byte string responses

@waynew seems to have looked at this and agrees with this approach. It needs a changelog and test (something simple, unit is fine), and then it'll be good to go!

fix returners.postgres inability to handle byte string responses

@ITJamie Any possibility you could add a test and changelog here? Thanks!

fix returners.postgres inability to handle byte string responses

I just tried to reproduce it locally, and it worked with `salt.utils.data.decode`. It seems your error msg and the function you pasted are unrelated because `save_load` is not called inside...

fix returners.postgres inability to handle byte string responses

Also, I forgot to mention this, but your solution seems to be breaking on something with a simple non-dict return, for instance with a `test.ping`. Using `salt.utils.data.decode` should handle all...