Caleb Beard

Results 32 comments of Caleb Beard

Hi @frebib, been looking at this. I think the `test.sls` you gave is expected to fail due to recursive requisites since your `pkg.installed` states will be aggregated to both require...

@rvandegrift Are you able to add a changelog file and a test for this?

@rvandegrift, given @SMillerDev 's comments, I do think we should allow this as an option to the mac pkg commands. Something like `interactive=True` by default.

Hey @bdrung, I've been working with Ubuntu 22.04 recently and haven't been able to replicate this failure. Are there any more details of your setup that may help us replicate...

> Not really a review, mostly just a question/request for more information: > > How do we test that this actually will expose a memory leak? That is, what do...

@nicholasmhughes The mac test is not one of the ones fixed by my PR from last week. I have seen that specific test fail a couple times before, but I...

@nicholasmhughes Are you able to test this on a mac? I'm wondering if debug statements in your code changes will show this test touching your changes unexpectedly. If you don't...

@nicholasmhughes Okay, so I've found what is causing the drastic failures. The test in question is actually touching your changes once (and seemingly _only_ once). On average, with my testing...