salt
salt copied to clipboard
add namespace to http_json external pillar method
What does this PR do?
It adds a namespace option to the http_json ext_pillar method just like csvpillar
What issues does this PR fix or reference?
Fixes: #61335
Previous Behavior
When using external Pillar data using ext_pillar.http_json all retrieved data is always available in the pillar root.
New Behavior
When using the new namespace option while using ext_pillar.http_json all retrieved data is available in the specified subkey.
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
- [x] Docs
- [x] Changelog - https://docs.saltproject.io/en/master/topics/development/changelog.html
- [ ] Tests written/updated http_json does not have a test yet - trivial change though
Commits signed with GPG?
No
Hi there! Welcome to the Salt Community! Thank you for making your first contribution. We have a lengthy process for issues and PRs. Someone from the Core Team will follow up as soon as possible. In the meantime, here’s some information that may help as you continue your Salt journey. Please be sure to review our Code of Conduct. Also, check out some of our community resources including:
- Community Wiki
- Salt’s Contributor Guide
- Join our Community Slack
- IRC on LiberaChat
- Salt Project YouTube channel
- Salt Project Twitch channel
There are lots of ways to get involved in our community. Every month, there are around a dozen opportunities to meet with other contributors and the Salt Core team and collaborate in real time. The best way to keep track is by subscribing to the Salt Community Events Calendar. If you have additional questions, email us at [email protected]. We’re glad you’ve joined our community and look forward to doing awesome things with you!
@ctramnitz Thanks for the PR, it looks like the pre-commit tests is failing above. You likely need to install the pre-commit hooks so those run and we'll need some tests for this change.
@ctramnitz Can you please fix the pre-commit issue? instructions on pre-commit can be found at https://docs.saltproject.io/en/latest/topics/development/contributing.html#pre-commit-and-nox-setup
There have been some modifications in this file which has led to conflicts, so could you rebase against those @ctramnitz? Also, a simple unit test for this will help it get across the line quicker.
I was not able to push to your branch. I opened a new PR that includes your commits and test coverage here: https://github.com/saltstack/salt/pull/62883
@calebj @whytewolf @garethgreenaway if you could review that new PR and we can get it in for 3006.
@calebj ... if you could review that new PR and we can get it in for 3006.
Did you mean @MKLeb ?
yes i did, apologies