Jakub Florek

Results 9 comments of Jakub Florek

Thanks! Good idea, I will look into it. I haven’t included support for macOS initially because Apple’s welcome sheets on it have significantly different design from the ones seen on...

>Would it be possible to do the changes that address my review comments from https://github.com/swiftlang/swift-syntax/pull/2748 in a separate PR again? Ok, I think this is a great idea. I've opened...

https://github.com/swiftlang/swift/pull/81209 @swift-ci Please test

> Without diving too deeply into the details: I am a little concerned about the cache eviction behavior and the fact that you need to manually call `evictEntriesWithoutHit` (which incidentally...

> That way we would get reasonable out-of-the-box behavior and don’t have an ever-growing cache but also have the ability to keep the cache size low in cases where the...

https://github.com/swiftlang/swift/pull/81209https://github.com/swiftlang/swift/pull/81209 @swift-ci Please test

https://github.com/swiftlang/swift/pull/81209 @swift-ci Please test Windows Platform