swift-syntax icon indicating copy to clipboard operation
swift-syntax copied to clipboard
verified publisher icon apple

[SwiftLexicalLookup][GSoC] Add switch, generic parameter and function scopes.

Open MAJKFL opened this issue 1 year ago • 2 comments

This PR introduces switch case, generic parameter/primary associated types and function scopes.

  • WithGenericParametersOrAssociatedTypesScopeSyntax and GenericParameterOrAssociatedTypeScopeSyntax are used to properly handle generic parameters/primary associated types by providing an alternative route for the lookup method before propagating it to parent scope.
  • switch now introduces names in it's case bodies
  • Function parameters are now passed into to the body
  • Includes some changes suggested in #2748

MAJKFL avatar Aug 07 '24 10:08 MAJKFL

Would it be possible to do the changes that address my review comments from https://github.com/swiftlang/swift-syntax/pull/2748 in a separate PR again? It just makes it easier to review.

ahoppen avatar Aug 07 '24 16:08 ahoppen

Would it be possible to do the changes that address my review comments from https://github.com/swiftlang/swift-syntax/pull/2748 in a separate PR again?

Ok, I think this is a great idea. I've opened #2789.

MAJKFL avatar Aug 08 '24 16:08 MAJKFL

@swift-ci please test

DougGregor avatar Aug 27 '24 14:08 DougGregor

@swift-ci please test Windows

DougGregor avatar Aug 27 '24 14:08 DougGregor

@swift-ci please test

DougGregor avatar Aug 28 '24 17:08 DougGregor

@swift-ci please test Windows

DougGregor avatar Aug 29 '24 05:08 DougGregor

@swift-ci please test

DougGregor avatar Sep 11 '24 15:09 DougGregor