swift-syntax icon indicating copy to clipboard operation
swift-syntax copied to clipboard

[SwiftLexicalLookup] Add dollar identifier, better extension handling and more `ASTScope` related fixes

Open MAJKFL opened this issue 1 year ago • 5 comments

This PR brings more ASTScope related fixes to SwiftLexicalLookup. Those include:

  • Prompting clients to lookup generic parameters of extended types inside extensions with LookupResult.lookInGenericParametersOfExtendedType.
  • Dollar identifier handling through LookupResult.mightIntroduceDollarIdentifiers result kind when looking up for identifier = nil and more explicit LookupName.dollarIdentifier when looking up for a particular dollar identifier.
  • Remove member and file scope handling to avoid confusion and incomplete member lookup.
  • Fix behavior of lookup from where clauses.
  • And more fine grained fixes.

MAJKFL avatar Oct 09 '24 10:10 MAJKFL

@swift-ci Please test

MAJKFL avatar Oct 09 '24 10:10 MAJKFL

@swift-ci please test Windows

DougGregor avatar Oct 09 '24 22:10 DougGregor

@swift-ci Please test

MAJKFL avatar Oct 10 '24 14:10 MAJKFL

@swift-ci please test Windows

DougGregor avatar Oct 10 '24 16:10 DougGregor

@swift-ci please test Windows

DougGregor avatar Oct 10 '24 16:10 DougGregor