Lucio Franco

Results 524 comments of Lucio Franco

I wonder if this can be achieved with https://docs.rs/prost-types/0.8.0/prost_types/struct.FileDescriptorProto.html instead of adding a new fn to the main prost trait which I would like to avoid.

At work we use any just fine so I don't see why not having this makes it impossible? I am not a huge fan of adding this method so its...

Yeah, I think we can try to merge something to support this in the next release. I would like to formalize a proper road map. I'd like to evaluate our...

Not totally sure, but the next release will remove cmake and compiling protoc so I think this will be a none issue in the future.

@hicder upgrading prost will no longer require cmake.

This seems like an interesting corner case, I don't see how we can fix this without exposing more fine grained controls which I am not super happy about. That said,...

Yeah, I think supporting this is a good idea. Will need to dig in a bit more to understand how other languages support this feature.

@tarcieri yes, though I don't remember (or couldn't find but didn't look super hard) if there was actually a concrete way to generate that url that isn't google specific etc.

Imho prost shouldn't be deriving Eq over encoded messages and esp protobuf which have a lot of backwards/forward compat featuers. C++ provides this https://developers.google.com/protocol-buffers/docs/reference/cpp/google.protobuf.util.message_differencer which we could try to implement...

Hi @LegNeato do you know of any precedent on how other protobuf implementations handle this?